Skip to content

Release/1071#143

Merged
deepin-bot[bot] merged 2 commits into
linuxdeepin:release/1071from
pppanghu77:release/1071
Jun 9, 2025
Merged

Release/1071#143
deepin-bot[bot] merged 2 commits into
linuxdeepin:release/1071from
pppanghu77:release/1071

Conversation

@pppanghu77
Copy link
Copy Markdown

@pppanghu77 pppanghu77 commented Jun 3, 2025 •
edited by sourcery-ai Bot
Loading

Summary by Sourcery

Enhancements:

  • Comment out the FAT32 filesystem registration in supportedfilesystems.cpp to effectively remove FAT32 support.

@wangrong1069 @pppanghu77
chore: Remove exfat-fuse dependency
cc9137a 
Remove exfat-fuse dependency.

Log: Remove exfat-fuse dependency
@wangrong1069 @pppanghu77
fix: Fix fail to format disk to FAT32
fcd8fd1 
Remove support for FAT32 format.

Log: Fix fail to format disk to FAT32
Bug: https://pms.uniontech.com/bug-view-299499.html
@deepin-ci-robot
Copy link
Copy Markdown

deepin-ci-robot commented Jun 3, 2025

deepin pr auto review

代码审查意见：

  1. Debian 控制文件修改：

    • 在 debian/control 文件中，移除了 exfat-fuse 依赖。需要确认这一改动是否与项目的其他部分兼容，以及是否有替代的文件系统支持库来处理 exFAT 文件系统。

  2. C++ 代码修改：

    • 在 service/diskoperation/supportedfilesystems.cpp 文件中，注释掉了 m_fsObjects[FS_FAT32] 的初始化。如果这个文件系统类型不再被支持，那么这个改动是合理的。但是，如果未来需要支持 FAT32 文件系统，则需要取消注释。
    • 注释掉的代码行 // m_fs_objects[FS_FAT32] = new FAT16(FS_FAT32); 可能是一个错误，因为 FAT16 应该是 FAT32 的正确类名。如果 FAT16 是 FAT32 的别名或子类，那么这个注释可能是正确的。如果 FAT16 不是 FAT32，那么这个注释应该被移除。

代码质量改进建议：

  • 确保所有注释掉的代码都有明确的注释说明为什么被注释掉，以便于未来的维护者理解。
  • 如果 FAT16 不是 FAT32 的正确类名，那么需要更正这个错误，并确保文件系统类名的一致性。

代码性能改进建议：

  • 如果 exfat-fuse 的移除不会影响项目的性能，那么这个改动是合理的。如果移除后性能有所下降，需要评估并可能重新添加 exfat-fuse。

代码安全建议：

  • 确保移除 exfat-fuse 不会影响对 exFAT 文件系统的支持，这可能会影响到文件系统的安全性。
  • 如果取消注释 m_fsObjects[FS_FAT32]，需要确保 FAT16 类能够正确处理 FAT32 文件系统，以避免潜在的安全问题。

总体来说，这些改动需要经过充分的测试和评估，以确保它们不会引入新的问题。

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 3, 2025

Reviewer's Guide

This PR prepares the 1071 release by disabling FAT32 support in the filesystem registry and updating Debian packaging metadata.

Sequence Diagram: Filesystem Retrieval for FS_FAT32 After Update

sequenceDiagram
    participant Client
    participant SFS as SupportedFileSystems

    Client->>SFS: getFileSystem(FS_FAT32)
    SFS-->>Client: nullptr (or error indicating filesystem not supported)
Loading

Updated Class Diagram for SupportedFileSystems and FAT32 Registration

classDiagram
  class SupportedFileSystems {
    -m_fsObjects: Map~FS_TYPE, FileSystem*~
    +SupportedFileSystems() : Constructor updated: no longer initializes m_fsObjects[FS_FAT32] with a FAT16 instance.
    +getFileSystem(type: FS_TYPE): FileSystem*
  }
  class FAT16 {
    +FAT16(FS_TYPE type)
    %% This class definition is unchanged by the PR.
  }
  class FileSystem {
    <<Interface>>
    %% Interface for filesystem operations.
  }

  SupportedFileSystems "1" o-- "*" FileSystem : m_fsObjects stores instances of
  FAT16 --|> FileSystem
  %% The specific instantiation and registration of FAT16 for FS_FAT32 
  %% within SupportedFileSystems constructor has been removed.
Loading

File-Level Changes

Change Details Files
Disabled FAT32 filesystem support initialization
  • Commented out the line instantiating FAT16 for the FAT32 enum in SupportedFileSystems constructor.
 service/diskoperation/supportedfilesystems.cpp
Updated Debian packaging metadata
  • Adjusted the control file for the Debian package configuration.
 debian/control
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link
Copy Markdown

deepin-ci-robot commented Jun 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: max-lvs, pppanghu77

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pppanghu77
Copy link
Copy Markdown
Author

pppanghu77 commented Jun 9, 2025

/merge

@deepin-bot deepin-bot Bot merged commit db3d1ce into linuxdeepin:release/1071 Jun 9, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-lvs max-lvs max-lvs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pppanghu77 @deepin-ci-robot @max-lvs @wangrong1069